netdev - Re: [PATCH 1/2] stmmac: request_irq when use an ext wake irq line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120209.140251.1155907203355431647.davem@davemloft.net>
Date:	Thu, 09 Feb 2012 14:02:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org, francesco.virlinzi@...com
Subject: Re: [PATCH 1/2] stmmac: request_irq when use an ext wake irq line

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Thu,  9 Feb 2012 08:55:13 +0100

> From: Francesco Virlinzi <francesco.virlinzi@...com>
> 
> In case of we use an external Wake-Up IRQ line
> (priv->wol_irq != dev->irq) we need to invoke the
> request_irq.
> 
> Signed-off-by: Francesco Virlinzi <francesco.virlinzi@...com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

You never free the IRQ in the driver close path, so it leaks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html