[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4F34B9B9.5090803@st.com>
Date: Fri, 10 Feb 2012 07:31:21 +0100
From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org, francesco.virlinzi@...com
Subject: Re: [PATCH 1/2] stmmac: request_irq when use an ext wake irq line
On 2/9/2012 8:02 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
> Date: Thu, 9 Feb 2012 08:55:13 +0100
>
>> From: Francesco Virlinzi <francesco.virlinzi@...com>
>>
>> In case of we use an external Wake-Up IRQ line
>> (priv->wol_irq != dev->irq) we need to invoke the
>> request_irq.
>>
>> Signed-off-by: Francesco Virlinzi <francesco.virlinzi@...com>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
>
> You never free the IRQ in the driver close path, so it leaks.
Yes you are right. I'm reviewing the patch and send it again.
Thx
peppe
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists