netdev - Re: [PATCH] stmmac: fix driver features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120209.153504.92022308276431620.davem@davemloft.net>
Date:	Thu, 09 Feb 2012 15:35:04 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	peppe.cavallaro@...com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] stmmac: fix driver features

From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
Date: Thu,  9 Feb 2012 11:56:33 +0100

> New GMAC chips can set the tx_coe and rx_csum
> flags by looking at the HW cap register and this
> happens during the open.
> This patch fixes the stmmac_fix_feature function that
> in some cases assumes that there is no HW csum
> because no flags are passed through the platform.
> As soon as the open method is called then the
> stmmac_fix_feature could want to turn-on the NETIF_F_RXCSUM
> or NETIF_F_ALL_CSUM.
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>

This is not the purpose of the fix_features method, it's meant to
ensure that the settings are valid.

It's not meant to "catch up" with settings you store in the internal
datastructures of your driver.

You need to do this at probe time, where the initial ->hw_features
and ->features values are set.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html