netdev - Re: [patch] isdn: type bug in isdn_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120209.154138.441017381710297517.davem@davemloft.net>
Date:	Thu, 09 Feb 2012 15:41:38 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	dan.carpenter@...cle.com, isdn@...ux-pingi.de,
	lucas.demarchi@...fusion.mobi, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] isdn: type bug in isdn_net_header()

From: Neil Horman <nhorman@...driver.com>
Date: Thu, 9 Feb 2012 06:34:11 -0500

> On Thu, Feb 09, 2012 at 01:46:47PM +0300, Dan Carpenter wrote:
>> We use len to store the return value from eth_header().  eth_header()
>> can return -ETH_HLEN (-14).  We want to pass this back instead of
>> truncating it to 65522 and returning that.
>> 
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>> ---
>> WARNING: Compile tested only.  I don't have this hardware.  Please check
>> that I am on the right track.
>> 
>> diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c
>> index 2339d73..802ab87 100644
>> --- a/drivers/isdn/i4l/isdn_net.c
>> +++ b/drivers/isdn/i4l/isdn_net.c
>> @@ -1901,7 +1901,7 @@ static int isdn_net_header(struct sk_buff *skb, struct net_device *dev,
>>  {
>>  	isdn_net_local *lp = netdev_priv(dev);
>>  	unsigned char *p;
>> -	ushort len = 0;
>> +	int len = 0;
>>  
>>  	switch (lp->p_encap) {
>>  		case ISDN_NET_ENCAP_ETHER:
>> 
> Looks reasonable
> Acked-by: Neil Horman <nhorman@...driver.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html