lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120209.154341.1329684491104733307.davem@davemloft.net> Date: Thu, 09 Feb 2012 15:43:41 -0500 (EST) From: David Miller <davem@...emloft.net> To: dan.carpenter@...cle.com Cc: rmody@...cade.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] bna: fix error handling of bnad_get_flash_partition_by_offset() From: Dan Carpenter <dan.carpenter@...cle.com> Date: Thu, 9 Feb 2012 13:49:34 +0300 > The current error handling doesn't work because we flash_part is a u32 > so the checks for negative error codes don't work. I considered making > things signed but I don't know the hardware enough to say if that's a > problem. Really, we don't use the error codes so just returning zero > for all problems is fine. > > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> Looks good, applied, thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists