netdev - Re: [RFC PATCH] rtnetlink: Add filter for VF info dump requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120208.201018.97784090083485473.davem@davemloft.net>
Date:	Wed, 08 Feb 2012 20:10:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	gregory.v.rose@...el.com
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC PATCH] rtnetlink: Add filter for VF info dump requests

From: Greg Rose <gregory.v.rose@...el.com>
Date: Tue, 07 Feb 2012 14:33:46 -0800

> Add a 256 bit filter to allow the user to filter which VFs' info will
> get displayed during the dump info request.  This is to fix a bug in
> which a an info dump request on a device with many VFs would overflow
> the recvmsg buffer which is allocated to max(8192, PAGE_SIZE).  A
> complimentary patch to the iproute2 ip tool will allow the user to
> set/clear individual VF filters.
> 
> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>

This isn't the idea.

I meant we have to add a generic u32 mask attribute to the GETLINK
requests, and it's a mask of "features".  One feature bit would be for
enabling the "VF" part of the dump, another bit would be for the
macvlan source address lists that are being proposed, etc.  Any new
auxiliarry information type we want to add to devide dumps, we have
to add a feature bit for in this mask.

And then you can't just stop there, you have to update all of the
logic related to min_ifinfo_dump_size to take into account the current
request's mask state.

In fact this means you must get rid of the min_info_dump_size global
variable altogether because the size is context dependent upon the
mask configuration of the current dump request.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html