netdev - Re: [net-next PATCH] be2net: event queue re-design

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120208.201230.2012432079493836273.davem@davemloft.net>
Date:	Wed, 08 Feb 2012 20:12:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	sathya.perla@...lex.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next PATCH] be2net: event queue re-design

From: Sathya Perla <sathya.perla@...lex.com>
Date: Wed, 8 Feb 2012 16:41:51 +0530

> -#define BE_MAX_EQD		96
> +#define BE_MAX_EQD		((u32)96)

What in the world is this garbage?  You either don't need it, or you
need to do it cleanly.  And doing it cleanly is adding a "U" postfix
or similar to the constant, not destroying how it looks it with an
ugly cast.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html