netdev - Re: BUG: unable to handle kernel NULL pointer dereference at 000000000000002c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120208.202651.97221367956126026.davem@davemloft.net>
Date:	Wed, 08 Feb 2012 20:26:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	s.priebe@...fihost.ag
Cc:	eric.dumazet@...il.com, gregkh@...uxfoundation.org,
	jwboyer@...il.com, hch@...radead.org, netdev@...r.kernel.org,
	david@...morbit.com, stable@...r.kernel.org
Subject: Re: BUG: unable to handle kernel NULL pointer dereference at
 000000000000002c

From: Stefan Priebe - Profihost AG <s.priebe@...fihost.ag>
Date: Fri, 03 Feb 2012 09:09:35 +0100

> Hi,
> 
> attached you find the patch files applying cleanly to 3.0.X.
> 
>>> I've made my own backport of the patch and removed at least 1-2
>>> dependencies. Anybody interested?
>>>
>> 
>> If you did the work, post it for review.
> 
> Thanks!

I think you backported way too much, the ->lookup_neigh() dst ops
abstraction is unnecessary, all of the neighbour hash function
changes are also completely unnecessary.

All you needed to backport is that bit that abstracts dst->neighbour()
behind helper routines.

The point of this exercise is not to keep backporting changes until
the subsequent patch applies cleanly, it's to backport the minimal
amount necessary to get the effect of the patch you're ultimately
interested in adding.

I'll work on coming up with something much more sensible tonight.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html