lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4F33A540.7020906@mvista.com> Date: Thu, 09 Feb 2012 14:51:44 +0400 From: Sergei Shtylyov <sshtylyov@...sta.com> To: Danny Kukawka <danny.kukawka@...ect.de> CC: netdev@...r.kernel.org, Danny Kukawka <dkukawka@...e.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Steve Glendinning <steve.glendinning@...c.com>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH 02/50] smsc95xx: use dev_hw_addr_random() instead of random_ether_addr() Hello. On 09-02-2012 1:10, Danny Kukawka wrote: > Use dev_hw_addr_random() instead of calling random_ether_addr() > to set addr_assign_type correctly to NET_ADDR_RANDOM. > Signed-off-by: Danny Kukawka<danny.kukawka@...ect.de> > --- > drivers/net/usb/smsc95xx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c > index d45520e..3a28e95 100644 > --- a/drivers/net/usb/smsc95xx.c > +++ b/drivers/net/usb/smsc95xx.c > @@ -614,7 +614,7 @@ static void smsc95xx_init_mac_address(struct usbnet *dev) > } > > /* no eeprom, or eeprom values are invalid. generate random MAC */ > - random_ether_addr(dev->net->dev_addr); > + dev_hw_addr_random(dev->net , dev->net->dev_addr); Should be no space before comma. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists