lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120209112848.GA2590@sirena.org.uk> Date: Thu, 9 Feb 2012 11:28:48 +0000 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Danny Kukawka <danny.kukawka@...ect.de> Cc: "David S. Miller" <davem@...emloft.net>, Danny Kukawka <dkukawka@...e.de>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Steve Glendinning <steve.glendinning@...c.com> Subject: Re: [PATCH 20/50] smsc911x: use dev_hw_addr_random() instead of random_ether_addr() On Wed, Feb 08, 2012 at 10:10:27PM +0100, Danny Kukawka wrote: > + if (dev->addr_assign_type & NET_ADDR_RANDOM) > + dev->addr_assign_type ^= NET_ADDR_RANDOM; It would be clearer to just write dev->addr_assign_type &= ~NET_ADDR_RANDOM; to clear the bit - the ^ takes more thinking. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists