lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6E62@saturn3.aculab.com> Date: Thu, 9 Feb 2012 13:15:37 -0000 From: "David Laight" <David.Laight@...LAB.COM> To: "Jeff Kirsher" <jeffrey.t.kirsher@...el.com>, <davem@...emloft.net> Cc: "Bruce Allan" <bruce.w.allan@...el.com>, <netdev@...r.kernel.org>, <gospo@...hat.com>, <sassmann@...hat.com> Subject: RE: [net-next 4/7] e1000e: use true/false for bool autoneg_false > - if (mac->autoneg_failed == 0) { > - mac->autoneg_failed = 1; > + if (mac->autoneg_failed == false) { > + mac->autoneg_failed = true; Don't check for equality with true/false. Booleans also work better if you avoid double-negatives. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists