netdev - Re: [net-next 4/7] e1000e: use true/false for bool autoneg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120209.133413.349832435589531136.davem@davemloft.net>
Date:	Thu, 09 Feb 2012 13:34:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 4/7] e1000e: use true/false for bool autoneg_false

From: "David Laight" <David.Laight@...LAB.COM>
Date: Thu, 9 Feb 2012 13:15:37 -0000

>  
>> -		if (mac->autoneg_failed == 0) {
>> -			mac->autoneg_failed = 1;
>> +		if (mac->autoneg_failed == false) {
>> +			mac->autoneg_failed = true;
> 
> Don't check for equality with true/false.
> Booleans also work better if you avoid double-negatives.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html