netdev - RE: [patch] bna: fix error handling of bnad_get_flash_partition_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86B1FB8B0BDD@HQ1-EXCH01.corp.brocade.com>
Date:	Fri, 10 Feb 2012 14:38:38 -0800
From:	Rasesh Mody <rmody@...cade.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"Adapter Linux Open SRC Team" 
	<adapter_linux_open_src_team@...cade.COM>
Subject: RE: [patch] bna: fix error handling of
 bnad_get_flash_partition_by_offset()

>From: Dan Carpenter [mailto:dan.carpenter@...cle.com]
>Sent: Thursday, February 09, 2012 11:16 PM
>
>On Thu, Feb 09, 2012 at 05:53:20PM -0800, Rasesh Mody wrote:
>>
>> We can't return 0 from the bnad_get_flash_partition_by_offset() on
>> error as the flash partition 0 is a optrom partition. Also we got
>> comments to return proper Linux error codes as ethtool application
>> expects so.
>
>It's already treated as an error.  A return value of zero means the user
>gets a return value of -EFAULT.  I'm slightly confused by your email.
>
>My patch was already merged into git.  Can you just send a patch which
>does what you want?  I don't know the subsystem well enough to say how
>you want zero returns to be handled if the original code was not
>correct.

I would like to take back my prior statement, we can return 0 from the bnad_get_flash_partition_by_offset on error. Flash partition 1 and not 0 is actually optrom, so there will be no need to  handle zero returns differently. Zero returns should be treated as an error and reported as -EFAULTS as its being done in current implementation. Apologies for the confusion.

Regards,
Rasesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html