netdev - Re: [PATCH v2 03/10] e1000e: Support RXFCS feature flag.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHXqBFLjuMRYFgifn_D4W6E1kNqzFeK1Sfe-pMwFhMuwmbsW9w@mail.gmail.com>
Date:	Fri, 10 Feb 2012 23:46:57 +0100
From:	Michał Mirosław <mirqus@...il.com>
To:	greearb@...delatech.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v2 03/10] e1000e: Support RXFCS feature flag.

2012/2/8  <greearb@...delatech.com>:
> From: Ben Greear <greearb@...delatech.com>
>
> This enables enabling/disabling reception of the Ethernet
> FCS.  This can be useful when sniffing packets.
>
> For e1000e, enabling RXFCS can change the default
> behaviour for how the NIC handles CRC.  Disabling RXFCS
> will take the NIC back to defaults, which can be configured
> as part of the module options.
[...]

This is not how I would expect the features to behave. Default value
should be set on probe() time, and when you disable RXFCS it should
just get disabled.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html