netdev - Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F36959C.50902@candelatech.com>
Date:	Sat, 11 Feb 2012 08:21:48 -0800
From:	Ben Greear <greearb@...delatech.com>
To:	Michał Mirosław <mirqus@...il.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.

On 02/11/2012 08:07 AM, Michał Mirosław wrote:
> 2012/2/11<greearb@...delatech.com>:
>> From: Ben Greear<greearb@...delatech.com>
> [...]
>> @@ -1951,9 +1956,11 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
>>         }
>>
>>         /* Get actual data size */
>> +       if (unlikely(dev->features&  NETIF_F_RXFCS))
>> +               fcs_pad = 4;
>>         actual_size = le16_to_cpu(rfd->actual_size)&  0x3FFF;
>> -       if (unlikely(actual_size>  RFD_BUF_LEN - sizeof(struct rfd)))
>> -               actual_size = RFD_BUF_LEN - sizeof(struct rfd);
>> +       if (unlikely(actual_size>  RFD_BUF_LEN + fcs_pad - sizeof(struct rfd)))
>> +               actual_size = RFD_BUF_LEN + fcs_pad - sizeof(struct rfd);
>
> BTW, Is this even triggered? I looks like this would indicate
> corruption in the descriptor.

No idea, but better safe than sorry unless someone can prove it never happens
in all cases...

Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html