netdev - Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328980060.5661.36.camel@edumazet-laptop>
Date:	Sat, 11 Feb 2012 18:07:40 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	greearb@...delatech.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 02/16] e100: Support RXFCS feature flag.

Le vendredi 10 février 2012 à 17:04 -0800, greearb@...delatech.com a
écrit :
> From: Ben Greear <greearb@...delatech.com>
> 
> This allows e100 to be configured to append the
> Ethernet FCS to the skb.
> 
> Useful for sniffing networks.
> 
> Signed-off-by: Ben Greear <greearb@...delatech.com>
> ---

Did you try this patch with 8021Q frames ?

You must change 

#define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN)

to :

#define RFD_BUF_LEN (sizeof(struct rfd) + VLAN_ETH_FRAME_LEN + ETH_FCS_LEN)

And also on various spots where VLAN_ETH_FRAME_LEN is used in this
driver...

nic->blank_rfd.size = cpu_to_le16(VLAN_ETH_FRAME_LEN);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html