netdev - Re: [PATCH] ixgbe: fix truesize calculation when merging active tail into lro skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329169382.2307.14.camel@jtkirshe-mobl>
Date:	Mon, 13 Feb 2012 13:43:02 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Christian Brunner <chb@....de>, netdev@...r.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH] ixgbe: fix truesize calculation when merging active
 tail into lro skb

On Mon, 2012-02-13 at 15:12 +0100, Eric Dumazet wrote:
> Le lundi 13 février 2012 à 14:52 +0100, Christian Brunner a écrit :
> > I'm seeing some page allocation failures with the ixgbe driver under heavy
> > load. While looking after it, I came accoss the truesize handling. I suspect,
> > that there is a small misstake in ixgbe_merge_active_tail(). (But I'm not
> > really sure).
> > 
> > Truesize allocation of the skb may be larger than skb->len, because
> > ixgbe is allocating PAGE_SIZE/2 for received fragments. Hence we 
> > should use the truesize of the tail when merging.
> > 
> > Signed-off-by: Christian Brunner <chb@....de>
> > ---
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > index a42b0b2..c4d25af 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> > @@ -1222,7 +1222,7 @@ static inline struct sk_buff *ixgbe_merge_active_tail(struct sk_buff *tail)
> >  
> >  	head->len += tail->len;
> >  	head->data_len += tail->len;
> > -	head->truesize += tail->len;
> > +	head->truesize += tail->truesize;
> >  
> >  	IXGBE_CB(tail)->head = NULL;
> >  
> 
> You forgot CC Intel guys, but they usually catch netdev traffic :)
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
> 
> 

Thanks Eric for bringing this to my attention.

Thanks Christian for the patch, I have added it to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)