netdev - Re: [PATCH] ixgbe: fix truesize calculation when merging active tail into lro skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329142322.2494.11.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Mon, 13 Feb 2012 15:12:02 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Christian Brunner <chb@....de>
Cc:	netdev@...r.kernel.org, Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH] ixgbe: fix truesize calculation when merging active
 tail into lro skb

Le lundi 13 février 2012 à 14:52 +0100, Christian Brunner a écrit :
> I'm seeing some page allocation failures with the ixgbe driver under heavy
> load. While looking after it, I came accoss the truesize handling. I suspect,
> that there is a small misstake in ixgbe_merge_active_tail(). (But I'm not
> really sure).
> 
> Truesize allocation of the skb may be larger than skb->len, because
> ixgbe is allocating PAGE_SIZE/2 for received fragments. Hence we 
> should use the truesize of the tail when merging.
> 
> Signed-off-by: Christian Brunner <chb@....de>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index a42b0b2..c4d25af 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -1222,7 +1222,7 @@ static inline struct sk_buff *ixgbe_merge_active_tail(struct sk_buff *tail)
>  
>  	head->len += tail->len;
>  	head->data_len += tail->len;
> -	head->truesize += tail->len;
> +	head->truesize += tail->truesize;
>  
>  	IXGBE_CB(tail)->head = NULL;
>  

You forgot CC Intel guys, but they usually catch netdev traffic :)

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html