netdev - Re: [RFC] netpoll: netpoll_poll_dev() should access dev->flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120214.144251.1481952602061158777.davem@davemloft.net>
Date:	Tue, 14 Feb 2012 14:42:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org, nhorman@...driver.com
Subject: Re: [RFC] netpoll: netpoll_poll_dev() should access dev->flags

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 14 Feb 2012 12:10:21 +0100

> commit 5a698af53f (bond: service netpoll arp queue on master device)
> use a dubious test : if (dev->priv_flags & IFF_SLAVE)
> 
> It seems to me IFF_SLAVE is present on dev->flags only ?
> 
> What am I missing ?

Like Neil, this looks correct to me, please submit this formally.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html