netdev - Re: [RFC] netpoll: netpoll_poll_dev() should access dev->flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120214132755.GA2434@neilslaptop.think-freely.org>
Date:	Tue, 14 Feb 2012 08:27:56 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Amerigo Wang <amwang@...hat.com>, netdev <netdev@...r.kernel.org>
Subject: Re: [RFC] netpoll: netpoll_poll_dev() should access dev->flags

On Tue, Feb 14, 2012 at 12:10:21PM +0100, Eric Dumazet wrote:
> commit 5a698af53f (bond: service netpoll arp queue on master device)
> use a dubious test : if (dev->priv_flags & IFF_SLAVE)
> 
> It seems to me IFF_SLAVE is present on dev->flags only ?
> 
> What am I missing ?
> 
I want to say there was a reason for checking priv_flags, but if there was, it
escapes me now.  Either way, ->flags is definately what we want now.  

Acked-by: Neil Horman <nhorman@...driver.com>

> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index 4ce473e..3d84fb9 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -205,7 +205,7 @@ static void netpoll_poll_dev(struct net_device *dev)
>  
>  	poll_napi(dev);
>  
> -	if (dev->priv_flags & IFF_SLAVE) {
> +	if (dev->flags & IFF_SLAVE) {
>  		if (dev->npinfo) {
>  			struct net_device *bond_dev = dev->master;
>  			struct sk_buff *skb;
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html