netdev - Re: [PATCH] 3c59x: shorten timer period for slave devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329252670.3054.85.camel@dcbw.foobar.com>
Date:	Tue, 14 Feb 2012 14:51:10 -0600
From:	Dan Williams <dcbw@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	klassert@...hematik.tu-chemnitz.de, jdelvare@...e.de,
	fubar@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] 3c59x: shorten timer period for slave devices

On Tue, 2012-02-14 at 21:27 +0100, Eric Dumazet wrote:
> Jean Delvare reported bonding on top of 3c59x adapters was not detecting
> network cable removal fast enough.
> 
> 3c59x indeed uses a 60 seconds timer to check link status if carrier is
> on, and 5 seconds if carrier is off.
> 
> This patch reduces timer period to 5 seconds if device is a bonding
> slave.

Maybe for posterity give some rationale as to why we feel we can reduce
it to 5 seconds for slaves instead of reducing the timer period in
general?  If you weren't party to this discussion that won't be apparent
from the commit log.

Dan

> Reported-by: Jean Delvare <jdelvare@...e.de>
> Acked-by: Jean Delvare <jdelvare@...e.de>
> Acked-by: Steffen Klassert <steffen.klassert@...unet.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> ---
>  drivers/net/ethernet/3com/3c59x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c
> index 1282f04..e463d10 100644
> --- a/drivers/net/ethernet/3com/3c59x.c
> +++ b/drivers/net/ethernet/3com/3c59x.c
> @@ -1841,7 +1841,7 @@ vortex_timer(unsigned long data)
>  		ok = 1;
>  	}
>  
> -	if (!netif_carrier_ok(dev))
> +	if (dev->flags & IFF_SLAVE || !netif_carrier_ok(dev))
>  		next_tick = 5*HZ;
>  
>  	if (vp->medialock)
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html