netdev - Re: [PATCH] 3c59x: shorten timer period for slave devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329253376.2555.14.camel@edumazet-laptop>
Date:	Tue, 14 Feb 2012 22:02:56 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Dan Williams <dcbw@...hat.com>
Cc:	David Miller <davem@...emloft.net>,
	klassert@...hematik.tu-chemnitz.de, jdelvare@...e.de,
	fubar@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] 3c59x: shorten timer period for slave devices

Le mardi 14 février 2012 à 14:51 -0600, Dan Williams a écrit :
> On Tue, 2012-02-14 at 21:27 +0100, Eric Dumazet wrote:
> > Jean Delvare reported bonding on top of 3c59x adapters was not detecting
> > network cable removal fast enough.
> > 
> > 3c59x indeed uses a 60 seconds timer to check link status if carrier is
> > on, and 5 seconds if carrier is off.
> > 
> > This patch reduces timer period to 5 seconds if device is a bonding
> > slave.
> 
> Maybe for posterity give some rationale as to why we feel we can reduce
> it to 5 seconds for slaves instead of reducing the timer period in
> general?  If you weren't party to this discussion that won't be apparent
> from the commit log.

Apparently, Andrew Morton considered firing a timer every 5 seconds was
too expensive. I am not sure we want to state this (probably old fact)
in the changelog. Anyway are these slow NICS still used in 2011 ? ;)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html