netdev - Re: [REGRESSION, PATCH] sky2 WOL fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120217110147.1c00b31d@nehalam.linuxnetplumber.net>
Date:	Fri, 17 Feb 2012 11:01:47 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Knut Petersen <Knut_Petersen@...nline.de>
Cc:	netdev@...r.kernel.org, dilieto@...eone.net,
	Mirko Lindner <mlindner@...konnect.de>,
	Ralph Roesler <rroesler@...konnect.de>, arekm@...en.pl,
	nitro@...room.net, Andrew Morton <akpm@...l.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [REGRESSION, PATCH] sky2 WOL fix

On Fri, 17 Feb 2012 19:21:53 +0100
Knut Petersen <Knut_Petersen@...nline.de> wrote:

> Your commit broke existing support for WOL on a number of boards.
> This is known to you and to bugzilla.kernel org since 2010.  A number of
> people complained about that, but nothing happened.
> 
> Neither your original commit description nor the description of the
> PXE_LegNat_Sel I found at other places indicate that setting
> PXE_LegNat_Sel could do any harm.

Please lose the attitude. Any support of sky2 is done as a minor side
project by me. People find a problem, I put in one fix, then someone else
complains and another fix goes in. The regressions happen a lot in power management
because the hardware is not well documented in this area and it is a complex
interaction of kernel, BIOS, motherboard, and general shittiness of implementations.
Because of that I am more likely to believe that what the Marvell code does
is more based on experience on other platforms. The out-of-tree Marvell
driver contains bits that are part of the Windows driver.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html