netdev - Re: [PATCH] Cleaning up code formatting errors in net/wireless pointed out by checkpatch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120217110602.2c4e762a@nehalam.linuxnetplumber.net>
Date:	Fri, 17 Feb 2012 11:06:02 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Luis Felipe Strano Moraes <lfelipe@...fusion.mobi>,
	linville@...driver.com, johannes@...solutions.net,
	davem@...emloft.net, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Cleaning up code formatting errors in net/wireless
 pointed out by checkpatch.

On Fri, 17 Feb 2012 10:45:44 -0800
Joe Perches <joe@...ches.com> wrote:

> On Fri, 2012-02-17 at 07:30 -0800, Luis Felipe Strano Moraes wrote:
> > These are mostly minor changes and they are being sent as one patch only in
> > order to cause the smallest amount of disruption.
> []
> > diff --git a/net/wireless/core.c b/net/wireless/core.c
> []
> > @@ -668,7 +668,7 @@ void wiphy_unregister(struct wiphy *wiphy)
> >  		mutex_lock(&rdev->devlist_mtx);
> >  		__count = rdev->opencount;
> >  		mutex_unlock(&rdev->devlist_mtx);
> > -		__count == 0;}));
> > +		__count == 0; }));
> 
> Inline statement expressions are pretty unusual
> for kernel sources.  Normally these are used via
> macro.
> 
> I'd try to make the statement expression visually
> distinct.  Something like:
> 
> 	wait_event(rdev->dev_wait,
> 		   ({
> 			   int __count;
> 			   mutex_lock(&rdev->devlist_mtx);
> 			   __count = rdev->opencount;
> 			   mutex_unlock(&rdev->devlist_mtx);
> 			   __count == 0;
> 		   })
> 		  );
> 

I prefer to see this done as an inline function

wait_event(rdev->dev_wait, is_foo_ready(rdev))

Also, in this case wrapping a condition with a mutex really is
meaningless because the state is longer protected out side the
protected region; in other words the mutex here is bogus and
provides no additional protection.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html