netdev - RE: [PATCH] Cleaning up code formatting errors in net/wireless pointed out by checkpatch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6E75@saturn3.aculab.com>
Date:	Fri, 17 Feb 2012 15:47:36 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Luis Felipe Strano Moraes" <lfelipe@...fusion.mobi>,
	<linville@...driver.com>
Cc:	<johannes@...solutions.net>, <davem@...emloft.net>,
	<linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Cleaning up code formatting errors in net/wireless pointed out by checkpatch.

 
> These are mostly minor changes and they are being sent as one 
> patch only in order to cause the smallest amount of disruption.

A lot of these changes don't seem to match what I thought the
linux kernel code style is.

eg:
>  void cfg80211_bss_age(struct cfg80211_registered_device *dev,
> -                      unsigned long age_secs);
> +		      unsigned long age_secs);
Args no longer lined up.

> -		pos = (u8 *) & hdr->addr4;
> +		pos = (u8 *) &hdr->addr4;
no space after cast?

> -	p1 = (u8*)(ht_capa);
> +	p1 = (u8 *)(ht_capa);
Still extra ().

I'm also not sure (personally) this sort of churn is useful.

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html