netdev - Re: [PATCH] Cleaning up code formatting errors in net/wireless pointed out by checkpatch.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHPwkG0yFX7Cac0NVc8obZ8N-07gck7bkTTCZvpCzY27wj1nzg@mail.gmail.com>
Date:	Fri, 17 Feb 2012 13:56:33 -0200
From:	Luis Felipe Strano Moraes <lfelipe@...fusion.mobi>
To:	David Laight <David.Laight@...lab.com>
Cc:	linville@...driver.com, johannes@...solutions.net,
	davem@...emloft.net, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Cleaning up code formatting errors in net/wireless
 pointed out by checkpatch.

On 17 February 2012 13:47, David Laight <David.Laight@...lab.com> wrote:
>
>> These are mostly minor changes and they are being sent as one
>> patch only in order to cause the smallest amount of disruption.
>
> A lot of these changes don't seem to match what I thought the
> linux kernel code style is.
>
> eg:
>>  void cfg80211_bss_age(struct cfg80211_registered_device *dev,
>> -                      unsigned long age_secs);
>> +                   unsigned long age_secs);
> Args no longer lined up.

It's ligned up here, perhaps mine (or yours) mail client is screwing
something up. This one was basically using tabs where they were
supposed to be.

>
>> -             pos = (u8 *) & hdr->addr4;
>> +             pos = (u8 *) &hdr->addr4;
> no space after cast?

There is a space there. The problem pointed by checkpatch was the
space between '&' and hdr.

>
>> -     p1 = (u8*)(ht_capa);
>> +     p1 = (u8 *)(ht_capa);
> Still extra ().
>
> I'm also not sure (personally) this sort of churn is useful.

As mentioned, those are mostly minor changes based on checkpatch's
output. Cleaning up only things that were specifically marked as
errors (so the extra parentheses there were not reported).

I don't think having lots of this kind of churn useful, thats why I
sent one patch only for the entire directory trying to clean up as
much as possible. There are some errors that I didn't clean up, but
they are mostly where an option was made on the source code to keep
code in a more readable way.

--lf

>
>        David
>
>

-- 
Luís Felipe Strano Moraes
Project Manager @ ProFUSION embedded systems
http://profusion.mobi
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html