lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 19 Feb 2012 21:28:02 +0100
From:	Nikola Pajkovsky <n.pajkovsky@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Gary Zambrano <zambrano@...adcom.com>, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Nikola Pajkovsky <n.pajkovsky@...il.com>
Subject: Re: [PATCH] b44: fix section mismatch warnings in b44.c

Dan Carpenter <dan.carpenter@...cle.com> writes:

> On Sun, Feb 19, 2012 at 03:45:54PM +0100, Nikola Pajkovsky wrote:
>> From: Nikola Pajkovsky <n.pajkovsky@...il.com>
>> 
>
> This changelog is not really helpful.
>
> Why did you remove an __exit anotation instead changing the callers?
> Obviously I looked at the code, so I can answer that question, but I
> shouldn't have to.  It should be explained in the changelog.

I will rephrase comment

> Sometimes I add in information about when the error message was
> introduced.
>
> It might also be nice to mention what the bad effects of this
> problem are.
>
>> Signed-off-by: Nikola Pajkovsky <n.pajkovsky@...il.com>
>                                    ^^^^^^^^^^^^^^^^^^^^^
> You're sending the patch from your redhat address; it's best to sign
> it with the redhat address as well.

oops, it should be from gmail

-- 
Nikola
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists