netdev - Re: [PATCH net] macvlan: Disable LRO on lowerdev; warn if it's turned back on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1329856136.2689.46.camel@bwh-desktop>
Date:	Tue, 21 Feb 2012 20:28:56 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	John Fastabend <john.r.fastabend@...el.com>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
	Shradha Shah <sshah@...arflare.com>,
	Patrick McHardy <kaber@...sh.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH net] macvlan: Disable LRO on lowerdev; warn if it's
 turned back on

On Tue, 2012-02-21 at 12:01 -0800, John Fastabend wrote:
> On 2/21/2012 11:13 AM, Ben Hutchings wrote:
> > Large Receive Offload (LRO) is only appropriate for packets that are
> > destined for the host, and should be disabled if received packets may
> > be forwarded.
> > 
> > Further, macvtap_skb_to_vnet_hdr() will BUG() on a packet received
> > with LRO (but not GRO).
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> > ---
> > I'm not really familiar with macvlan so I'm not certain that this should
> > be applied to all modes.
> > 
> > Ben.
> > 
> >  drivers/net/macvlan.c |    7 +++++++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> 
> But this patch assumes the macvlan is forwarding traffic to a guest
> via macvtap. Which is an assumption that may not be true.
> 
> It seems more appropriate for the macvtap driver to do these checks
> after all its the driver that may BUG() with LRO.

That's what I thought at first, but then I looked through what macvlan
was doing and it certainly appears to re-transmit skbs in all modes.
That's not valid when gso_size != 0 and gso_type == 0.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html