netdev - Re: [PATCH] ipv6: Fix problem with expired dst cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F473A8E.9080402@cn.fujitsu.com>
Date:	Fri, 24 Feb 2012 15:21:50 +0800
From:	Gao feng <gaofeng@...fujitsu.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Fix problem with expired dst cache

于 2012年02月24日 14:51, Eric Dumazet 写道:
> Le vendredi 24 février 2012 à 14:20 +0800, Gao feng a écrit :
>> if the ipv6 dst cache copy from the dst witch generated by ICMPV6 RA packet.
>> this dst cache will not be checked expire because it has no RTF_EXPIRES flag
>> So this dst cache always be used until the dst gc run.
>>
>> add a pointer in struct rt6_info,point to where the dst cache copy from.
>> in func rt6_check_expired check if rt6->info->rt6i_copy is expired.
>>
> 
> Sorry, I really dont understand what you are saying.

Just because ipv6 dst cache has no RTF_EXPIRES flag,
so even this dst cache has expired,it will be used until the gc run.

> 
> Also, adding a pointer to a structure without holding a reference on it
> is suspicious.
> 

OK,I think there is no use to hold a reference.
the dst cache will be deleted before the pointer,
So this pointer will be always usefull.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html