lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1331494587-12196-6-git-send-email-Julia.Lawall@lip6.fr> Date: Sun, 11 Mar 2012 20:36:25 +0100 From: Julia Lawall <Julia.Lawall@...6.fr> To: Chas Williams <chas@....nrl.navy.mil> Cc: kernel-janitors@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible From: Julia Lawall <Julia.Lawall@...6.fr> Convert call to request_irq so that the last argument is the same as the second argument of the subsequent call to free_irq. Without this property, free_irq does nothing. I have chosen to keep the call to free_irq as is, because its second argument is more like its first argument. Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> --- Not tested. I don't know if I have made the right choice. drivers/atm/eni.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 956e9ac..89e7223 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -1800,7 +1800,8 @@ static int __devinit eni_start(struct atm_dev *dev) DPRINTK(">eni_start\n"); eni_dev = ENI_DEV(dev); - if (request_irq(eni_dev->irq,&eni_int,IRQF_SHARED,DEV_LABEL,dev)) { + if (request_irq(eni_dev->irq, &eni_int, IRQF_SHARED, DEV_LABEL, + eni_dev)) { printk(KERN_ERR DEV_LABEL "(itf %d): IRQ%d is already in use\n", dev->number,eni_dev->irq); error = -EAGAIN; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists