lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <201203112058.q2BKwBCS024617@cmf.nrl.navy.mil> Date: Sun, 11 Mar 2012 16:58:11 -0400 From: "Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil> To: Julia Lawall <Julia.Lawall@...6.fr> cc: kernel-janitors@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible i am pretty sure that request_irq() shouldnt be changed but rather free_irq() changed. the last argument of request_irq() is passed to the interrupt routine (ent_int in this case). if you change that you need to update the interrupt routine. fixing free_irq would be easier. In message <1331494587-12196-6-git-send-email-Julia.Lawall@...6.fr>,Julia Lawall writes: >Convert call to request_irq so that the last argument is the same as the >second argument of the subsequent call to free_irq. Without this >property, free_irq does nothing. > >I have chosen to keep the call to free_irq as is, because its second >argument is more like its first argument. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists