lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120311.234808.1919218898572322534.davem@davemloft.net> Date: Sun, 11 Mar 2012 23:48:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: santoshprasadnayak@...il.com Cc: sony.chacko@...gic.com, rajesh.borundia@...gic.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug. From: santosh nayak <santoshprasadnayak@...il.com> Date: Mon, 12 Mar 2012 12:08:23 +0530 > From: Santosh Nayak <santoshprasadnayak@...il.com> > > Fix endian bug. > > Signed-off-by: Santosh Nayak <santoshprasadnayak@...il.com> This is a very non-trivial patch, therefore the terse commit message and the lack of any comments in this code is unacceptable. This commit message is not only terse, it's wrong. You're not fixing an endian bug, you're fixing several of them. Explain everything in your commit message. > req.words[0] = cpu_to_le64(cmd); > - req.words[1] = cpu_to_le64(ip); > + memcpy(&req.words[1], &ip, sizeof(u32)); Nobody is going to read that and have any idea why it's correct unless they happen to be able to discover the long thread you guys had this past week working out how to do this change correctly. Putting a comment here for the rest of us mere mortals is therefore absolutely required. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists