lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120311.234846.455580505379366792.davem@davemloft.net> Date: Sun, 11 Mar 2012 23:48:46 -0700 (PDT) From: David Miller <davem@...emloft.net> To: joe@...ches.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] net: Convert printks to pr_<level> From: Joe Perches <joe@...ches.com> Date: Sun, 11 Mar 2012 21:36:11 -0700 > Use a more current kernel messaging style. > > Convert a printk block to print_hex_dump. > Coalesce formats, align arguments. > Use %s, __func__ instead of embedding function names. > > Some messages that were prefixed with <foo>_close are > now prefixed with <foo>_fini. Some ah4 and esp messages > are now not prefixed with "ip ". > > The intent of this patch is to later add something like > #define pr_fmt(fmt) "IPv4: " fmt. > to standardize the output messages. > > Text size is trivially reduced. (x86-32 allyesconfig) > > $ size net/ipv4/built-in.o* > text data bss dec hex filename > 887888 31558 249696 1169142 11d6f6 net/ipv4/built-in.o.new > 887934 31558 249800 1169292 11d78c net/ipv4/built-in.o.old > > Signed-off-by: Joe Perches <joe@...ches.com> Applied, thanks a lot Joe. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists