netdev - Re: [PATCH 4/8] net/mlx4_en: Set max rate-limit for a TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F607373.7090001@mellanox.com>
Date:	Wed, 14 Mar 2012 12:31:15 +0200
From:	Amir Vadai <amirv@...lanox.com>
To:	John Fastabend <john.r.fastabend@...el.com>
CC:	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	Roland Dreier <roland@...estorage.com>,
	Oren Duer <oren@...lanox.com>,
	Amir Vadai <amirv@...lanox.co.il>
Subject: Re: [PATCH 4/8] net/mlx4_en: Set max rate-limit for a TC

On 03/13/2012 08:26 PM, John Fastabend wrote:
> On 3/13/2012 10:21 AM, Amir Vadai wrote:
>> From: Amir Vadai<amirv@...lanox.co.il>
>>
>> Set max rate-limit using sysfs file /sys/class/net/<interface>/qos/ratelimit
>>
>> To set, enter a space separated list of values in units of 100Mbps.  For
>> example to set ratelimit of 5G to TC0 and 10G for the reset on eth2 issue:
>> echo 50 100 100 100 100 100 100 100 100>  /sys/class/net/eth2/qos/ratelimit
>>
>> Signed-off-by: Amir Vadai<amirv@...lanox.co.il>
>> ---
>>
>> We used sysfs since max bw isn't part of the ETS / DCBX NL support, and we're
>> open to other suggestions to add generic support for max bw, e.g add call to
>> the DCBX NL API.
>>
>
> Its not really part of DCB so adding it to DCBnl seems a bit forced. But how
> about adding it as an attribute of the mqprio which "knows" about the queue
> groupings?
See my answer below
>
> Does the rate limiter take into account the user priority to tc mapping or
> is it really just a group of queues with a rate limit? The code makes it
> look like it really is per 802.1Q traffic class.
This is true, the rate limiter is per 802.1Q traffic class, and the HW 
is using the UP to TC mapping when enforcing it.
That's why it can't be added to mqprio, which is a group of queues and 
not 802.1Q traffic class.
>
> .John

Thanks,
Amir
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html