netdev - Re: [PATCH 4/8] net/mlx4_en: Set max rate-limit for a TC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F607623.9060904@mellanox.com>
Date:	Wed, 14 Mar 2012 12:42:43 +0200
From:	Amir Vadai <amirv@...lanox.com>
To:	Dave Taht <dave.taht@...il.com>
CC:	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	Roland Dreier <roland@...estorage.com>,
	Oren Duer <oren@...lanox.com>,
	Amir Vadai <amirv@...lanox.co.il>
Subject: Re: [PATCH 4/8] net/mlx4_en: Set max rate-limit for a TC

On 03/13/2012 09:16 PM, Dave Taht wrote:
> On Tue, Mar 13, 2012 at 10:21 AM, Amir Vadai<amirv@...lanox.com>  wrote:
>> From: Amir Vadai<amirv@...lanox.co.il>
>>
>> Set max rate-limit using sysfs file /sys/class/net/<interface>/qos/ratelimit
>>
>> To set, enter a space separated list of values in units of 100Mbps.  For
>> example to set ratelimit of 5G to TC0 and 10G for the reset on eth2 issue:
>> echo 50 100 100 100 100 100 100 100 100>  /sys/class/net/eth2/qos/ratelimit
>
> At least in my world, rates go down as low as 128k.
>
> If this 'qos' sys value is intended to be a generic mechanism to be
> used instead of (say) htb,
> for more than one type of ethernet device.... I would argue that the
> units need to be specified.
>
> Similarly what else is intended to live below the 'qos' subdir?

This sys value is specific to our driver, and will be shown only on 
mlx4_en netdev's.

We're open to suggestions to make it a generic sysfs entry. If it will 
really be generic, we will sure have well known units (for example KB) 
and we'll do the translation in our driver.

Thanks,
Amir
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html