netdev - Re: [PATCH] fix sierra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1331753062.2564.6.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Wed, 14 Mar 2012 19:24:22 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Andreas Schwab <schwab@...ux-m68k.org>
CC:	Maris Paupe <marisp@...lv>, <epasheva@...rrawireless.com>,
	<rfiler@...rrawireless.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH]  fix sierra_net endianess bug

On Wed, 2012-03-14 at 16:26 +0100, Andreas Schwab wrote:
> Maris Paupe <marisp@...lv> writes:
> 
> > I have found that sierra_net does not work properly on big-endian
> > systems, it works if bytes are flipped in this particular location.
> 
> That should probably be fixed in sierra_net_get_fw_attr (and the author
> of sierra_net_get_fw_attr should be hit with a cluestick to not use
> kmalloc for allocating a single u16).

You cannot use stack buffers for DMA, which includes all USB I/O.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html