netdev - Re: [PATCH] fix sierra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2pqce51o4.fsf@igel.home>
Date:	Wed, 14 Mar 2012 22:10:35 +0100
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	Maris Paupe <marisp@...lv>, <epasheva@...rrawireless.com>,
	<rfiler@...rrawireless.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH]  fix sierra_net endianess bug

Ben Hutchings <bhutchings@...arflare.com> writes:

> On Wed, 2012-03-14 at 16:26 +0100, Andreas Schwab wrote:
>> Maris Paupe <marisp@...lv> writes:
>> 
>> > I have found that sierra_net does not work properly on big-endian
>> > systems, it works if bytes are flipped in this particular location.
>> 
>> That should probably be fixed in sierra_net_get_fw_attr (and the author
>> of sierra_net_get_fw_attr should be hit with a cluestick to not use
>> kmalloc for allocating a single u16).
>
> You cannot use stack buffers for DMA, which includes all USB I/O.

Ok, sorry, I didn't know that.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html