netdev - Re: [PATCH net-next 17/34] bnx2: stop using net_device.{base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1331844459.5136.83.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
Date:	Thu, 15 Mar 2012 13:47:39 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Francois Romieu" <romieu@...zoreil.com>
cc:	netdev@...r.kernel.org, "David Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 17/34] bnx2: stop using
 net_device.{base_addr, irq}.

On Thu, 2012-03-15 at 14:57 +0100, Francois Romieu wrote:
> @@ -8480,22 +8469,21 @@ bnx2_init_one(struct pci_dev *pdev, const
> struct pci_device_id *ent)
>                 goto error;
>         }
>  
> -       netdev_info(dev, "%s (%c%d) %s found at mem %lx, IRQ %d, node
> addr %pM\n",
> -                   board_info[ent->driver_data].name,
> +       netdev_info(dev, "%s (%c%d) %s found at mem %p, IRQ %d, "
> +                   "node addr %pM\n",
> board_info[ent->driver_data].name,
>                     ((CHIP_ID(bp) & 0xf000) >> 12) + 'A',
>                     ((CHIP_ID(bp) & 0x0ff0) >> 4),
> -                   bnx2_bus_string(bp, str),
> -                   dev->base_addr,
> -                   bp->pdev->irq, dev->dev_addr);
> +                   bnx2_bus_string(bp, str), bp->regview,

I think we should either remove the string "found at mem %lx", or keep
it the same as before by using pci_resource_start(pdev, 0) to display
the BAR address.  Changing it to display the mapped kernel address is
not useful to the user.

> +                   pdev->irq, dev->dev_addr);
>  
>         return 0;
>  
>  error:
> -       if (bp->regview)
> -               iounmap(bp->regview);
> +       iounmap(bp->regview);
>         pci_release_regions(pdev);
>         pci_disable_device(pdev);
>         pci_set_drvdata(pdev, NULL);
> +err_free:
>         free_netdev(dev);
>         return rc;
>  } 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html