netdev - Re: [PATCH net-next 00/34] Pull request for 'davem-next.base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120315.150526.353003174998399838.davem@davemloft.net>
Date:	Thu, 15 Mar 2012 15:05:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 00/34] Pull request for
 'davem-next.base_addr.removal' branch

From: Francois Romieu <romieu@...zoreil.com>
Date: Thu, 15 Mar 2012 14:56:57 +0100

> Please pull from branch 'davem-next.base_addr.removal' in repository
> 
> git://violet.fr.zoreil.com/romieu/linux davem-next.base_addr.removal
> 
> to get the changes below.

I don't think you can blindly override outl, readl, etc. with defines
without first properly undefining them.  Otherwise via indirect header
inclusion the asm/io.h definition will be present already and this
will result in compiler failures.

Frankly, I think you should just do it right, by overriding some
private macro for this purpose in such drivers and then do the
necessary sed 's/outl/foow32/' or whatever over the whole driver.

Please also address the other feedback you've received so far.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html