netdev - Re: [PATCH] wimax/i2400m: fix erroneous NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120316.020246.792440183234503872.davem@davemloft.net>
Date:	Fri, 16 Mar 2012 02:02:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, inaky.perez-gonzalez@...el.com
Subject: Re: [PATCH] wimax/i2400m: fix erroneous NETDEV_TX_BUSY use

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 14 Mar 2012 12:21:44 -0700

> A driver start_xmit() method cannot free skb and return NETDEV_TX_BUSY,
> since caller is going to reuse freed skb.
> 
> In fact netif_tx_stop_queue() / netif_stop_queue() is needed before
> returning NETDEV_TX_BUSY or you can trigger a ksoftirqd fatal loop.
> 
> In case of memory allocation error, only safe way is to drop the packet
> and return NETDEV_TX_OK
> 
> Also increments tx_dropped counter
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com>

Applied, but Eric:

> @@ -367,38 +367,28 @@ netdev_tx_t i2400m_hard_start_xmit(struct sk_buff
> *skb,

Your mailer chopped up that line and I had to fix it up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html