netdev - Re: [PATCH] net/hyperv: fix erroneous NETDEV_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 02:02:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	haiyangz@...rosoft.com
Cc:	eric.dumazet@...il.com, greearb@...delatech.com,
	netdev@...r.kernel.org, kys@...rosoft.com,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH] net/hyperv: fix erroneous NETDEV_TX_BUSY use

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Wed, 14 Mar 2012 20:29:13 +0000

> 
> 
>> -----Original Message-----
>> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
>> Sent: Wednesday, March 14, 2012 4:15 PM
>> To: Haiyang Zhang
>> Cc: Ben Greear; David Miller; netdev; KY Srinivasan; Greg Kroah-Hartman
>> Subject: RE: [PATCH] net/hyperv: fix erroneous NETDEV_TX_BUSY use
>> 
>> On Wed, 2012-03-14 at 20:00 +0000, Haiyang Zhang wrote:
>> 
>> > Actually, I'm working on this bug, and have a patch under our internal
>> > review now. My fix is actually not freeing the SKB, and return
>> NETDEV_TX_BUSY.
>> >
>> > Even if the vmbus ring buffer is busy currently, it can be available
>> during
>> > the next re-try, because the host is taking away data from ring buffer.
>> The
>> > stop/wake queue mechanism is in the netvsc.c file.
>> >
>> > In the out-of-memory case, dropping packet and return NETDEV_TX_OK seems
>> fine.
>> 
>> That will be fine for net-next.
>> 
>> I sent a patch for current kernels, where obvious and minimal fixes
>> apply.
> 
> Sounds good. Thanks.
> 
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> 

APplied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html