| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1331903413-11426-1-git-send-email-santoshprasadnayak@gmail.com> Date: Fri, 16 Mar 2012 18:40:13 +0530 From: santosh nayak <santoshprasadnayak@...il.com> To: hjlipp@....de Cc: tilman@...p.cc, isdn@...ux-pingi.de, gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org, linux-media@...r.kernel.org, kernel-janitors@...r.kernel.org, Santosh Nayak <santoshprasadnayak@...il.com> Subject: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts fails. From: Santosh Nayak <santoshprasadnayak@...il.com> If locking attempt was interrupted by a signal then we should return -EINTR so that caller can take appropriate action. We have 3 callers: gigaset_probe(), gigaset_tty_open() and gigaset_probe(). Each caller tries to free allocated memory if lock fails. This is possible if we returns -EINTR. Signed-off-by: Santosh Nayak <santoshprasadnayak@...il.com> --- drivers/isdn/gigaset/common.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c index 7679270..2d10f3a 100644 --- a/drivers/isdn/gigaset/common.c +++ b/drivers/isdn/gigaset/common.c @@ -903,7 +903,7 @@ int gigaset_start(struct cardstate *cs) unsigned long flags; if (mutex_lock_interruptible(&cs->mutex)) - return 0; + return -EINTR; spin_lock_irqsave(&cs->lock, flags); cs->connected = 1; -- 1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists