netdev - Re: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts fails.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120316.231856.1071253468993560433.davem@davemloft.net>
Date:	Fri, 16 Mar 2012 23:18:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	santoshprasadnayak@...il.com
Cc:	hjlipp@....de, tilman@...p.cc, isdn@...ux-pingi.de,
	gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-media@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] isdn: Return -EINTR in gigaset_start() if locking
 attempts fails.

From: santosh nayak <santoshprasadnayak@...il.com>
Date: Fri, 16 Mar 2012 18:40:13 +0530

> We have 3 callers: gigaset_probe(), gigaset_tty_open() and
> gigaset_probe(). Each caller tries to free allocated memory
> if lock fails. This is possible if we returns -EINTR.

Look again at the callers.

They interpret "0" as an error, so your patch would break the driver.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html