netdev - Re: [PATCH net-next] ethtool: Added a field fw dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 14:10:30 -0700
From:	Anirban Chakraborty <anirban.chakraborty@...gic.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>,
	Manish Chopra <manish.chopra@...gic.com>
Subject: Re: [PATCH net-next] ethtool: Added a field fw dump_state



On 3/16/12 11:27 AM, "Ben Hutchings" <bhutchings@...arflare.com> wrote:

>On Fri, 2012-03-16 at 10:58 -0700, Anirban Chakraborty wrote:
>> From: Manish chopra <manish.chopra@...gic.com>
>> 
>> This field is added to enable/disable firmware dump.
>> 
>> Signed-off-by: Manish chopra <manish.chopra@...gic.com>
>> Signed-off-by: Anirban Chakraborty <anirban.chakraborty@...gic.com>
>> ---
>>  include/linux/ethtool.h |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>> 
>> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
>> index e1d9e0e..6ebc7de 100644
>> --- a/include/linux/ethtool.h
>> +++ b/include/linux/ethtool.h
>> @@ -666,15 +666,22 @@ struct ethtool_flash {
>>   * 	 %ETHTOOL_GET_DUMP_DATA and this is returned as dump length by
>>driver
>>   * 	 for %ETHTOOL_GET_DUMP_FLAG command
>>   * @data: data collected for get dump data operation
>> + * @dump_state: state of the firmware dump. which can be
>>enable/disable.
>>   */
>> +
>> +#define ETH_FW_DUMP_ENABLE	1
>> +#define ETH_FW_DUMP_DISABLE	0
>> +
>>  struct ethtool_dump {
>>  	__u32	cmd;
>>  	__u32	version;
>>  	__u32	flag;
>>  	__u32	len;
>>  	__u8	data[0];
>> +	__u8	dump_state;
>
>Don't be ridiculous.

Yeah I know, especially when there is a flag field already present there.
The only
reason, we considered for adding it is to keep the backward compatibility
of scripts.
Right now, the flag field sets/gets the dump level of fw. If we use it to
control the
dump state, then it would break the existing scripts, if there are any.

-Anirban


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html