[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.02.1203172225080.2364@localhost6.localdomain6>
Date: Sat, 17 Mar 2012 22:28:47 +0100 (CET)
From: Julia Lawall <julia.lawall@...6.fr>
To: David Miller <davem@...emloft.net>
cc: santoshprasadnayak@...il.com, hjlipp@....de, tilman@...p.cc,
isdn@...ux-pingi.de, gigaset307x-common@...ts.sourceforge.net,
netdev@...r.kernel.org, linux-media@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] isdn: Return -EINTR in gigaset_start() if locking attempts
fails.
On Sat, 17 Mar 2012, David Miller wrote:
> From: santosh prasad nayak <santoshprasadnayak@...il.com>
> Date: Sat, 17 Mar 2012 21:26:14 +0530
>
>> Caller is interpreting 0 in opposite way of normal sequence.
>> Thats why I misunderstood it.
>
> The simple fact is that you didn't even look at the code at the call
> sites when you wrote this patch, and that's the first thing anyone is
> going to do when reviewing it.
>
> Therefore your laziness results in more useless work for other people.
> I just wanted to point out how selfish and anti-social this kind of
> behavior is.
Not to pour too much salt on a wound, but just 5 lines above the patch
site is the comment:
* Return value:
* 1 - success, 0 - error
And the error label also returns 0. So there is a lot of local
information that one can use to see what protocol the function follows.
That said, it's a bit too bad that two protocols have to coexist.
julia
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists