netdev - Re: [PATCH net-next 1/3] gianfar: Add support for byte queue limits.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP=VYLpNhJGZ0MS6Y6gWvbzn3vg-jHP0_kSBd6_Xxq_6hRyo8g@mail.gmail.com>
Date:	Sun, 18 Mar 2012 17:04:04 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	davem@...emloft.net, therbert@...gle.com, netdev@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH net-next 1/3] gianfar: Add support for byte queue limits.

On Sun, Mar 18, 2012 at 4:20 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> Le dimanche 18 mars 2012 à 12:56 -0400, Paul Gortmaker a écrit :
>
> ...
>
>>                * we add this skb back into the pool, if it's the right size
>> @@ -2557,13 +2568,15 @@ static int gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue)
>>       }
>>
>>       /* If we freed a buffer, we can restart transmission, if necessary */
>> -     if (__netif_subqueue_stopped(dev, tx_queue->qindex) && tx_queue->num_txbdfree)
>> -             netif_wake_subqueue(dev, tx_queue->qindex);
>> +     if (__netif_subqueue_stopped(dev, tqi) && tx_queue->num_txbdfree)
>> +             netif_wake_subqueue(dev, tqi);
>>
>
> You can use netif_tx_queue_stopped(txq) here instead of
> __netif_subqueue_stopped(dev, tqi)

Yes, and it looks better too.  I will do it as a patch #4 since I think
there is some small value in leaving the above patch chunk alone,
since it makes it clear that it was just the introduction of a local
variable and the code was otherwise unchanged here.

Will resend shortly....

Thanks,
Paul.
---

>
>>       /* Update dirty indicators */
>>       tx_queue->skb_dirtytx = skb_dirtytx;
>>       tx_queue->dirty_tx = bdp;
>>
>> +     netdev_tx_completed_queue(txq, howmany, bytes_sent);
>> +
>>       return howmany;
>>  }
>>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html