lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP=VYLpzpbLVAJ6=L1jdoZWcyAWPPKGMFTKBVU=7=HR+qTxwwA@mail.gmail.com> Date: Sun, 18 Mar 2012 19:24:44 -0400 From: Paul Gortmaker <paul.gortmaker@...driver.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: davem@...emloft.net, therbert@...gle.com, netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH net-next 4/4] gianfar: use netif_tx_queue_stopped instead of __netif_subqueue_stopped On Sun, Mar 18, 2012 at 5:55 PM, Eric Dumazet <eric.dumazet@...il.com> wrote: > On Sun, 2012-03-18 at 17:39 -0400, Paul Gortmaker wrote: >> The __netif_subqueue_stopped() just does the following: >> >> struct netdev_queue *txq = netdev_get_tx_queue(dev, queue_index); >> return netif_tx_queue_stopped(txq); >> >> and since we already have the txq in scope, we can just call that >> directly in this case. >> >> Suggested-by: Eric Dumazet <eric.dumazet@...il.com> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com> >> --- >> drivers/net/ethernet/freescale/gianfar.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c >> index 6e66cc3..d9428f0 100644 >> --- a/drivers/net/ethernet/freescale/gianfar.c >> +++ b/drivers/net/ethernet/freescale/gianfar.c >> @@ -2565,7 +2565,7 @@ static int gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue) >> } >> >> /* If we freed a buffer, we can restart transmission, if necessary */ >> - if (__netif_subqueue_stopped(dev, tqi) && tx_queue->num_txbdfree) >> + if (netif_tx_queue_stopped(txq) && tx_queue->num_txbdfree) >> netif_wake_subqueue(dev, tqi); >> >> /* Update dirty indicators */ > > Please change netif_wake_subqueue() as well ;) I looked at this earlier when I added patch #4 but I was concerned about the different semantics. The netif_wake_subqueue() just returns on a netpoll_trap but the other netif_tx_wake_queue() actually calls netif_tx_start_queue() for the same netpoll_trap instance. Maybe that is OK, but I didn't want to be changing the behaviour of subtleties in stuff where I am clearly still learning. Thanks, Paul. > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists