lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Mar 2012 18:04:15 -0400 (EDT) From: David Miller <davem@...emloft.net> To: nick.jones@...work-box.com Cc: eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics From: Nick Jones <nick.jones@...work-box.com> Date: Sun, 18 Mar 2012 01:43:39 +0800 > + return ERR_CAST(-ENOMEM); Really, please, stop wasting my time. There is no way your compiler didn't emit a warning for that garbage. Furthermore, callers are only ready to handle NULL vs. non-NULL as return values from this function. So this return value you are adding will result in crashes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists