netdev - Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1332222481.25418.540.camel@nbnickhq4>
Date:	Tue, 20 Mar 2012 13:48:01 +0800
From:	Nick Jones <nick.jones@...work-box.com>
To:	David Miller <davem@...emloft.net>
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6
 packets to prevent tainting dst metrics

On Mon, 2012-03-19 at 18:04 -0400, David Miller wrote: 
> From: Nick Jones <nick.jones@...work-box.com>
> Date: Sun, 18 Mar 2012 01:43:39 +0800
> 
> > +		return ERR_CAST(-ENOMEM);
> 
> Really, please, stop wasting my time.  There is no way your compiler
> didn't emit a warning for that garbage.
> 

This is really sloppy, I apologise.  I'll work on tightening up my
workflow for build testing, runtime testing and patch submission before
I bother you again.

> Furthermore, callers are only ready to handle NULL vs. non-NULL as
> return values from this function.  So this return value you are adding
> will result in crashes.

This one I did check.  icmp6_dst_alloc returns error encoded pointers
and all call sites test the return value with IS_ERR, I simply didn't
understand the correct formatting macro, nor check the build properly.
I think you got it mixed up with ip6_dst_alloc

The 'return NULL' at the bottom of the second fragment was a bug, but
this again exposes my newness to kernel patch submission workflow: that
bug was fixed recently and this patch wouldn't have applied, further
wasting your time... wonderful.

I'll let the merge window close to let things settle down for you before
bringing this fix up again.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html