lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120320.031041.1349041584421003180.davem@davemloft.net> Date: Tue, 20 Mar 2012 03:10:41 -0400 (EDT) From: David Miller <davem@...emloft.net> To: nick.jones@...work-box.com Cc: eric.dumazet@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next v4] ipv6: Allocate unique metrics for icmp6 packets to prevent tainting dst metrics From: Nick Jones <nick.jones@...work-box.com> Date: Tue, 20 Mar 2012 13:48:01 +0800 > On Mon, 2012-03-19 at 18:04 -0400, David Miller wrote: >> Furthermore, callers are only ready to handle NULL vs. non-NULL as >> return values from this function. So this return value you are adding >> will result in crashes. > > This one I did check. icmp6_dst_alloc returns error encoded pointers > and all call sites test the return value with IS_ERR, I simply didn't > understand the correct formatting macro, nor check the build properly. > I think you got it mixed up with ip6_dst_alloc Indeed you're right on this one. We changed this recently, in fact. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists